[PATCH SET - 3/3] linux-2.5.73_lost-tick-corner-fix_A0

john stultz (johnstul@us.ibm.com)
30 Jun 2003 15:26:23 -0700


This patch catches a corner case in the lost-tick compensation code.
There is a check to see if we overflowed between reads of the two time
sources, however should the high res time source be slightly slower then
what we calibrated, its possible to trigger this code when no ticks have
been lost. This patch adds an extra check to insure we have seen more
then one tick before we check for this overflow. This seems to resolve
the remaining "time doubling" issues that I've seen reported. This patch
applies ontop of lost-tick-speedstep-fix_A1.

Please consider for inclusion in your tree.

thanks
-john

timer_cyclone.c | 2 +-
timer_tsc.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff -Nru a/arch/i386/kernel/timers/timer_cyclone.c b/arch/i386/kernel/timers/timer_cyclone.c
--- a/arch/i386/kernel/timers/timer_cyclone.c Mon Jun 30 13:53:56 2003
+++ b/arch/i386/kernel/timers/timer_cyclone.c Mon Jun 30 13:53:56 2003
@@ -88,7 +88,7 @@
* between cyclone and pit reads (as noted when
* usec delta is > 90% # of usecs/tick)
*/
- if (abs(delay - delay_at_last_interrupt) > (900000/HZ))
+ if (lost && abs(delay - delay_at_last_interrupt) > (900000/HZ))
jiffies++;
}

diff -Nru a/arch/i386/kernel/timers/timer_tsc.c b/arch/i386/kernel/timers/timer_tsc.c
--- a/arch/i386/kernel/timers/timer_tsc.c Mon Jun 30 13:53:56 2003
+++ b/arch/i386/kernel/timers/timer_tsc.c Mon Jun 30 13:53:56 2003
@@ -205,7 +205,7 @@
* between tsc and pit reads (as noted when
* usec delta is > 90% # of usecs/tick)
*/
- if (abs(delay - delay_at_last_interrupt) > (900000/HZ))
+ if (lost && abs(delay - delay_at_last_interrupt) > (900000/HZ))
jiffies++;
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/