[PATCH 2.4-ac] Proper APIC version identification

Pallipadi, Venkatesh (venkatesh.pallipadi@intel.com)
Wed, 2 Jul 2003 16:57:34 -0700


This is a MIME-formatted message. If you see this text it means that your
E-mail software does not support MIME-formatted messages.

--=_courier-17045-1057190577-0001-2
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable

Hi,

The boot issue with DL760 G2 issue with Hyper-Threading (16-way
logical) was root-caused to be coming from hardcoding of apic-version
during the acpi boot-up code. The attached patch fixes the issue, by
reading in the actual apic version. This apic-version is used later in
the boot process, to identify whether the processor supports xAPIC or
not. And that in turn was resulting in boot failure.

Please include in the ac-patchset.

Refer following lkml threads for detailed the problem description:
Subject: SUMMARY: DL760 G2 issue with Hyper-Threading:
Subject: PROBLEM: DL760 G2 issue on 2.4.21 with Hyper-Threading

Thanks,
-Venkatesh

--- linux-2.4.21-ac2/arch/i386/kernel/mpparse.c.org 2003-06-30
12:52:21.000000000 -0700
+++ linux-2.4.21-ac2/arch/i386/kernel/mpparse.c 2003-07-01
16:07:40.000000000 -0700
@@ -999,7 +999,14 @@
=20
processor.mpc_type =3D MP_PROCESSOR;
processor.mpc_apicid =3D id;
- processor.mpc_apicver =3D 0x10; /* TBD: lapic version */
+
+ /*
+ * mp_register_lapic_address() which is called before the
+ * current function does the fixmap of FIX_APIC_BASE.
+ * Read in the correct APIC version from there
+ */
+ processor.mpc_apicver =3D apic_read(APIC_LVR);
+=09
processor.mpc_cpuflag =3D (enabled ? CPU_ENABLED : 0);
processor.mpc_cpuflag |=3D (boot_cpu ? CPU_BOOTPROCESSOR : 0);
processor.mpc_cpufeature =3D (boot_cpu_data.x86 << 8) |=20

--=_courier-17045-1057190577-0001-2
Content-Type: application/octet-stream; name="acpi_apicversion.patch"
Content-Transfer-Encoding: base64
Content-Description: acpi_apicversion.patch
Content-Disposition: attachment;
filename="acpi_apicversion.patch"

LS0tIGxpbnV4LTIuNC4yMS1hYzIvYXJjaC9pMzg2L2tlcm5lbC9tcHBhcnNlLmMub3JnCTIwMDMt
MDYtMzAgMTI6NTI6MjEuMDAwMDAwMDAwIC0wNzAwCisrKyBsaW51eC0yLjQuMjEtYWMyL2FyY2gv
aTM4Ni9rZXJuZWwvbXBwYXJzZS5jCTIwMDMtMDctMDEgMTY6MDc6NDAuMDAwMDAwMDAwIC0wNzAw
CkBAIC05OTksNyArOTk5LDE0IEBACiAKIAlwcm9jZXNzb3IubXBjX3R5cGUgPSBNUF9QUk9DRVNT
T1I7CiAJcHJvY2Vzc29yLm1wY19hcGljaWQgPSBpZDsKLQlwcm9jZXNzb3IubXBjX2FwaWN2ZXIg
PSAweDEwOyAvKiBUQkQ6IGxhcGljIHZlcnNpb24gKi8KKworCS8qCisJICogbXBfcmVnaXN0ZXJf
bGFwaWNfYWRkcmVzcygpIHdoaWNoIGlzIGNhbGxlZCBiZWZvcmUgdGhlCisJICogY3VycmVudCBm
dW5jdGlvbiBkb2VzIHRoZSBmaXhtYXAgb2YgRklYX0FQSUNfQkFTRS4KKwkgKiBSZWFkIGluIHRo
ZSBjb3JyZWN0IEFQSUMgdmVyc2lvbiBmcm9tIHRoZXJlCisJICovCisJcHJvY2Vzc29yLm1wY19h
cGljdmVyID0gYXBpY19yZWFkKEFQSUNfTFZSKTsKKwkKIAlwcm9jZXNzb3IubXBjX2NwdWZsYWcg
PSAoZW5hYmxlZCA/IENQVV9FTkFCTEVEIDogMCk7CiAJcHJvY2Vzc29yLm1wY19jcHVmbGFnIHw9
IChib290X2NwdSA/IENQVV9CT09UUFJPQ0VTU09SIDogMCk7CiAJcHJvY2Vzc29yLm1wY19jcHVm
ZWF0dXJlID0gKGJvb3RfY3B1X2RhdGEueDg2IDw8IDgpIHwgCg==

--=_courier-17045-1057190577-0001-2--