Re: [PATCH] cryptoloop

Christoph Hellwig (hch@infradead.org)
Fri, 4 Jul 2003 10:41:34 +0100


On Fri, Jul 04, 2003 at 10:43:10AM +0300, Jari Ruusu wrote:
> Changing transfer function prototype may be a tiny speed improvement for one
> implementation that happens to use unoptimal API, but at same time be tiny
> speed degration to other implementations that use more saner APIs. I am
> unhappy with that change, because I happen to maintain four such transfers
> that would be subject to tiny speed degration.

You've so far only made ubacked claims in this thread. Show the
numbers and tell us why your implementation is faster and show the
numbers and explain why this change should make your module slower.

If you can't benefit from using the page frame + offset the worst
thing you'd have to do is doing the kmap yourself instead of loop.c
doing it. And no, kmap doesn't get magically slower when called from
a different module.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/