Re: [PATCH - RFC] [1/5] 64-bit network statistics - generic net

[Jan-Benedict Glaw]

This is a MIME-formatted message.  If you see this text it means that your
E-mail software does not support MIME-formatted messages.

--=_courier-9071-1057312336-0001-2
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, 2003-07-03 22:31:27 -0400, Jeff Sipek <[e-mail]>
wrote in message <[e-mail]>:
Content-Description: clearsigned data
> The variables for network statistics (in struct net_device_stats) are uns=
igned=20
> longs. On 32-bit architectures, this makes them overflow every 4GB or 2^3=
2=20
> packets. The following series of patches [against 2.5.74] makes the=20
> statistics variable type configurable. The default is to leave everything=
 the=20
> way it was (unsigned long). However, when NETSTATS64 is set in the config=
,=20
> the statistics use 64-bit variables (u_int64_t) - this works only on 32-b=
it=20
> architectures.

Well... I don't really like to break userspace, but why don't we simply
make packet/traffic counters long long / u_int64_t? This way, we'd
simply keep almost all drivers untouched and only need to fiddle with
some sprints()/printk() statements?

Really, how many programs use the current statistics? I'd prefer to
modify them over adding strange patches like this one to the kernel...

MfG, JBG

--=20
   Jan-Benedict Glaw       [e-mail]    . [phone]
   "Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg
    fuer einen Freien Staat voll Freier B=FCrger" | im Internet! |   im Ira=
k!
      ret =3D do_actions((curr | FREE_SPEECH) & ~(IRAQ_WAR_2 | DRM | TCPA));

--=_courier-9071-1057312336-0001-2
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE/BU1BHb1edYOZ4bsRAohsAJ0ervTO3drSzsx4hkTksc7LjqwfDACdHI49
5o1DYEODlS3uUd2AepfBU/g=
=FQOh
-----END PGP SIGNATURE-----

--=_courier-9071-1057312336-0001-2--