Redundant memset in AIO read_events

Chen, Kenneth W (kenneth.w.chen@intel.com)
Tue, 8 Jul 2003 16:17:12 -0700


This is a MIME-formatted message. If you see this text it means that your
E-mail software does not support MIME-formatted messages.

--=_courier-31532-1057706328-0001-2
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable

OK, here is another one. In the top level read_events() function in
fs/aio.c, a struct io_event is instantiated on the stack (variable ent).
It calls aio_read_evt() function which will fill the entire io_event
structure into variable ent. What's the point of zeroing when copy
covers the same memory area? Possible a debug code left around?

- Ken
<<aio.ent.patch>>=20

--=_courier-31532-1057706328-0001-2
Content-Type: application/octet-stream; name="aio.ent.patch"
Content-Transfer-Encoding: base64
Content-Description: aio.ent.patch
Content-Disposition: attachment;
filename="aio.ent.patch"

ZGlmZiAtTnVyIGxpbnV4LTIuNS43NC9mcy9haW8uYyBsaW51eC0yLjUuNzQuYWlvL2ZzL2Fpby5j
DQotLS0gbGludXgtMi41Ljc0L2ZzL2Fpby5jCVN1biBKdW4gMjIgMTE6MzI6NDMgMjAwMw0KKysr
IGxpbnV4LTIuNS43NC5haW8vZnMvYWlvLmMJVHVlIEp1bCAgOCAxNjoxMTo1MCAyMDAzDQpAQCAt
ODA1LDEwICs4MDUsNiBAQA0KIAlzdHJ1Y3QgaW9fZXZlbnQJCWVudDsNCiAJc3RydWN0IHRpbWVv
dXQJCXRvOw0KIA0KLQkvKiBuZWVkZWQgdG8gemVybyBhbnkgcGFkZGluZyB3aXRoaW4gYW4gZW50
cnkgKHRoZXJlIHNob3VsZG4ndCBiZSANCi0JICogYW55LCBidXQgQyBpcyBmdW4hDQotCSAqLw0K
LQltZW1zZXQoJmVudCwgMCwgc2l6ZW9mKGVudCkpOw0KIAlyZXQgPSAwOw0KIA0KIAl3aGlsZSAo
bGlrZWx5KGkgPCBucikpIHsNCg==

--=_courier-31532-1057706328-0001-2--