Re: Small cleanups for input

Russell King (rmk@arm.linux.org.uk)
Wed, 9 Jul 2003 00:23:22 +0100


On Wed, Jul 09, 2003 at 01:14:19AM +0200, Pavel Machek wrote:
> > This needs to be migrated to the new power management code.
>
> What exactly should it do? Suspend machine? Then it needs to do
> equivalent of "echo 3 > /proc/acpi/sleep", but I do not think we have
> generic interface for that...

It looks like it was intended to call an old version of the suspend
code on ARM devices - probably the power button on the iPAQ.

The correct function (in the ARM tree) is now called "suspend()" and
deals with suspending the devices and then whatever is needed to cause
the CPU to go into deep sleep - ie, the user visible "power off" state.

Absolutely nothing to do with swsusp I'm afraid. 8)

> > > ===================================================================
> > > --- linux.orig/drivers/input/power.c 2003-06-24 11:54:39.000000000 +0200
> > > +++ linux/drivers/input/power.c 2003-04-18 16:19:02.000000000 +0200
> > > @@ -45,9 +45,7 @@
> > > static int suspend_button_pushed = 0;
> > > static void suspend_button_task_handler(void *data)
> > > {
> > > - //extern void pm_do_suspend(void);
> > > udelay(200); /* debounce */
> > > - //pm_do_suspend();
> > > suspend_button_pushed = 0;
> > > }

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/