Re: ->direct_IO API change in current 2.4 BK

Marcelo Tosatti (marcelo@conectiva.com.br)
Wed, 9 Jul 2003 15:08:10 -0300 (BRT)


On Wed, 9 Jul 2003, Marc-Christian Petersen wrote:

> On Wednesday 09 July 2003 19:46, Marcelo Tosatti wrote:
>
> Hi Marcelo,
>
> > > > > > I just got a nice XFS oops due to the direct_IO API change in
> > > > > > 2.4. Guys, this is a STABLE series and APIs are supposed to be
> > > > > > exactly that, _STABLE_. If you really think O_DIRECT on NFS is soo
> > > > > > important please add a ->direct_IO2 for NFS like the reiserfs
> > > > > > read_inode2 hack.
> > >
> > > I wonder why -aa and -wolk don't have these problems with O_DIRECT vs.
> > > XFS.
> > Do they have the NFS DIRECT IO patch?
> Yes. If not, my sentence would be superflous ;)

Ok, right. Well, I dont know why it doesnt happen there. Maybe not enough
testing?

Anyway, I'm going to revert the NFS DIRECT IO patch because, as Christoph
mentioned, breaks the API.

I except another solution from Trond (maybe ->direct_IO2).

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/