I respectfully disagree, then.
The 2.5 direct_IO API is already different from 2.4, so, changing
the 2.4 stable API implies creating yet another different version of
When this situation presented itself earlier, with reiserfs, the
solution was ->read_inode2. I think that same situation applies here.
Having the stable API change, conditional on a define, is really
nasty and IMO will create maintenance and support headaches down
the line. I do not recall Linux VFS _ever_ having a hook's definition
conditional. We should not start now...
We need a 2.4-specific solution for this. ->direct_IO2 should suffice,
and it follows historical example.
XFS, ocfs, and others need only to test the HAVE_NEW_24_DIRECT_IO
In the core kernel implementation, it is trivial to say "if direct_IO2
is non-NULL, use that, otherwise use direct_IO", without needing to make
any code conditional at all.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to email@example.com
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/