Re: Regarding drivers/ide/ide-cd.c in 2.5.72

[Jens Axboe]

On Fri, Jul 11 2003, Andy Polyakov wrote:
> > > > > ... In the nutshell the problem is that [as it is
> > > > > now] every failed SG_IO request is replayed second time without data
> > > > > transfer. ... Suggested patch
> > > > > overcomes this problem by immediately purging the failed SG_IO request
> > > > > from the request queue.
> > > >
> > > > Patch looks fine, care to resend actually trying to follow the style in
> > > > the file in question?
> > >
> > > Revised to my best ability for follow the coding style of file in
> > > question. A:-)
> > 
> > Much better, thanks :)
> 
> And it slipped through again:-( Sharpen up! BTW, the proposed patch

Calm down, I pass the fixes on and sometimes the just fall through the
cracks (and not always just my cracks).

> fixes even http://marc.theaimsgroup.com/?t=105634805100001&r=1&w=2,
> where induced kernel crash occurs upon packet replay. Applicable to
> up to 2.5.75. A.

It looks reasonable, I'm wondering whether the ->ide_dma_off() isn't too
harsh in the first place. But we can look at that later.

-- 
Jens Axboe