Re: Sound Config.in patch/cleanup

[Brian Gerst]

Michael Elizabeth Chastain wrote:
> 
> Hi Brian,
> Hi kernel hackers,
> 
> It Works For Me (TM).  I read it and didn't find any obvious errors.
> I also tried it with menuconfig and oldconfig.
> 
> Here's another cosmetic suggestion: add two spaces to each of the
> prompts like this:
> 
>     hex '  I/O base for SB Check from manual of the card' SBC_BASE 220

I was already thinking of that after I sent the second patch.

> Speaking of sound driver configuration, I have an idea for handling
> the PSS, Maui, and Trix drivers with standard configuration.  The old
> configuration method asks the user for a filename, opens that file,
> and runs bin2hex or hex2hex on the file to make a file such as
> maui_boot.h.  We could do this in standard configuration as follows:
> 
>     # drivers/sound/Config.in:
>     bool 'Do you have OSWF.MOT file' HAVE_MAUI_BOOT
>     if [ "$HAVE_MAUI_BOOT" = "y" ]; then
>         string 'Enter full pathname name of OSWF.MOT file' MAUI_BOOT_FILE
>     endif
> 
>     # drivers/sound/Makefile:
>     ifeq ($(HAVE_MAUI_BOOT),y)
>     maui_boot.h: $(MAUI_BOOT_FILE) bin2hex
>             bin2hex < $< > $@
>     endif
> 
> The 'string' command is already implemented for config, oldconfig, and
> xconfig.  Menuconfig takes a few more lines.
> 
> In fact, I spent this morning coding this all up, and it works on my
> system.  I'll have a patch ready for testing in a day or two.

This would be great.  This would remove all dependency on the old
(crappy) sound configure program, and allow it to be fully integrated
with the kernel config (which is A Good Thing).

-- 

						Brian Gerst