Linux-kernel mailing list archive 1998-25,: Re: linux-2.1.106-ac3-ac4: Some weirdness in fs/ext/ patches

# Re: linux-2.1.106-ac3-ac4: Some weirdness in fs/ext/ patches

Bill Hawes (whawes@transmeta.com)
Sun, 21 Jun 1998 22:43:05 -0700

- Messages sorted by: [ date ][ thread ][ subject ][ author ]
- Next message: Mathieu Bouchard: "Re: RT cache management"
- Previous message: Pine.LNX.3.96.980622002417.14546B-100000@nidhogg.ham.muohio.edu: "Pine.LNX.3.96.980622002417.14546B-100000@nidhogg.ham.muohio.edu"
- Maybe in reply to: Horst von Brand: "linux-2.1.106-ac3-ac4: Some weirdness in fs/ext/ patches"
- Next in thread: David S. Miller: "Re: linux-2.1.106-ac3-ac4: Some weirdness in fs/ext/ patches"

Horst von Brand wrote:

> OTOH, in the above mentioned part of the patch I see that the following
> line is being added to truncate.c:
>
> static u32 le32_zero = cpu_to_le32(0);
>
> I don't see any possible changes in the representation of 0 when going from
> big to little endian ;) Anyway, this kind of stuff should be #defined as a
> constant, if really needed.

The original code went to the trouble of converting endian-ness for 0, so I
thought it best to keep this in place. Who knows, perhaps some future
architecture will need it.

> There are also several printk()'s that don't have a <LEVEL>, and the
> indentation of those is weird. Just debugging scaffolding?

Yes, the messages are just for debugging, and should occur infrequently. I'll
remove them in the next rev.

Regards,
Bill

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu

- Next message: Mathieu Bouchard: "Re: RT cache management"
- Previous message: Pine.LNX.3.96.980622002417.14546B-100000@nidhogg.ham.muohio.edu: "Pine.LNX.3.96.980622002417.14546B-100000@nidhogg.ham.muohio.edu"
- Maybe in reply to: Horst von Brand: "linux-2.1.106-ac3-ac4: Some weirdness in fs/ext/ patches"
- Next in thread: David S. Miller: "Re: linux-2.1.106-ac3-ac4: Some weirdness in fs/ext/ patches"