Re: 2.1.114 fails build on i386

[Michael H. Warfield]

Hey Linus!

Linus Torvalds enscribed thusly:

> Use this instead (or rather, in _addition_ to the patch David suggested).

> It fixes the problem at a negligible cost in size, but I much prefer
> losing a few bytes of memory than to have different code for SMP or not
> SMP.

	Well...  Close...  It fixed one problem for me (the Sig11) but
left me with this:

] gcc -D__KERNEL__ -I/mnt2/src/linux-2.1.114/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -pipe -fno-strength-reduce -m486 -malign-loops=2 -malign-jumps=2 -malign-functions=2 -DCPU=586   -c -o init_task.o init_task.c
] init_task.c:24: parse error before `,'
] init_task.c:24: warning: missing braces around initializer for `init_task_union.task.sigmask_lock'
] init_task.c:24: warning: initialization makes integer from pointer without a cast
] init_task.c:24: warning: braces around scalar initializer for `init_task_union.task.sig'
] init_task.c:24: warning: braces around scalar initializer for `init_task_union.task.sig'
] init_task.c:24: warning: initialization makes integer from pointer without a cast
] init_task.c:24: warning: initialization makes integer from pointer without a cast
] make[1]: *** [init_task.o] Error 1
] make[1]: Leaving directory `/mnt2/src/linux-2.1.114/arch/i386/kernel'
] make: *** [linuxsubdirs] Error 2
] alcove:/usr/src/linux# 

	Alcove is a RedHat 5.1 system.  Same problems on a RedHat 4.1 system.

> 		Linus

> ----
> --- v2.1.114/linux/include/asm-i386/spinlock.h       Mon Aug  3 17:48:28 1998
> +++ linux/include/asm-i386/spinlock.h Mon Aug  3 23:16:10 1998
> @@ -10,8 +10,8 @@
>  /*
>   * Your basic spinlocks, allowing only a single CPU anywhere
>   */
> -typedef struct { } spinlock_t;
> -#define SPIN_LOCK_UNLOCKED { }
> +typedef struct { int gcc_is_bugggy; } spinlock_t;
> +#define SPIN_LOCK_UNLOCKED { 0 }
>  
>  #define spin_lock_init(lock)	do { } while(0)
>  #define spin_lock(lock)		do { } while(0)

	Regards,
	Mike
-- 
 Michael H. Warfield    |  [phone]   |  [e-mail]
  (The Mad Wizard)      |  [phone]   |  http://www.wittsend.com/mhw/
  NIC whois:  MHW9      |  An optimist believes we live in the best of all
 PGP Key: 0xDF1DD471    |  possible worlds.  A pessimist is sure of it!