Linux-kernel mailing list archive 1998-31,: fb and kdev_t

# fb and kdev_t

Andries.Brouwer@cwi.nl
Wed, 5 Aug 1998 22:58:34 +0200 (MET DST)

- Messages sorted by: [ date ][ thread ][ subject ][ author ]
- Next message: H. Peter Anvin: "Re: SMBFS: Question..."
- Previous message: Shawn Leas: "Re: DEVFSv50 and /dev/fb? (or /dev/fb/? ???)"

It must be almost half a year ago that I last ran a kernel
with large device numbers. Hope to have one based on 2.1.114
later tonight.
However, I notice that the number of non-kdev_t-clean
source files has increased again. In fb.h we have

#define GET_FB_IDX(node) (MINOR(node) >> FB_MODES_SHIFT)

and GET_FB_IDX is commonly applied to the node field
of a struct fb_info, declared as

int node;

But kdev_t.h has (in my source)

#define MINOR(dev) ((dev)->minor)

in other words, it is forbidden to apply MINOR to an integer
in kernel space, it can be applied to a kdev_t only.
Please correct this.

(I do not supply a patch since this part of the kernel
source is still being patched daily - no doubt 2.1.114
is outdated.)

Andries

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html

- Next message: H. Peter Anvin: "Re: SMBFS: Question..."
- Previous message: Shawn Leas: "Re: DEVFSv50 and /dev/fb? (or /dev/fb/? ???)"