Re: [patch] vesafb panning: scrollback support and nice speedup

Gerd Knorr (kraxel@goldbach.isdn.cs.tu-berlin.de)
Fri, 7 Aug 1998 21:31:02 +0200 (CEST)


On Fri, 7 Aug 1998, Ulf Carlsson wrote:

> > + if (screen_info.pages < 2)
> > + ywrap = ypan = 0; /* need at least two screen pages */
>
> Why do we need atleast to pages?

Picked this up from another fb driver and assumed there is some specific
reason to do so.

> Anyway, this line doesn't work.

[ ... ]

> > + if (ypan) {
> > + printk("vesafb: scrolling: ypan using protected mode interface\n");
> > + vesafb_defined.yres_virtual = video_height * screen_info.pages;

[ ... ]

> Ok, almost the same as before, in ypan, set vesafb_defined.yres_virtual to
> video_size / video_linelength, and it works better, here atleast.

It does exactly what it is supported to do. It uses the # of full screen
pages available according to the BIOS. Probably a bit less then the whole
video memory in most cases. I prefare conservative defaults...

> Something has to be done with those memcopies when we reach the end of memory. I
> think a redraw would speed up everything a lot.

It will for sure.

[ fbcon.c says: ]
> /* This cannot be used together with ypan or ywrap */
> void fbcon_redraw_bmove(struct display *p, int sy, int sx, int dy, int dx, int h, int w)

Why does'nt it work with ypan? Just not implemented yet?

Gerd

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html