Re: [PATCH] i386 get_wchan() bugs (fs/proc/array.c)

[Jamie Lokier]

On Tue, Dec 15, 1998 at 01:44:23AM +0100, Andrea Arcangeli wrote:
> > 		stack_page = (unsigned long)p;
> > 		esp = p->tss.esp;
> >-		if (!stack_page || esp < stack_page || esp >= 8188+stack_page)
> >+		if (!stack_page || esp < stack_page || esp > 8188+stack_page)
> 
> Wrong. Dereferencing esp will not fault if it will be equal to
> 8188+stack_page. 

Which is why the patch is correct.  You are too tired :-)

> Tell me if it' s too late to thing to these issues ;)

-- Jamie