Linux-kernel mailing list archive 1998-50,: Re: NFS client write out corrupted file?

# Re: NFS client write out corrupted file?

Linus Torvalds (torvalds@transmeta.com)
Thu, 17 Dec 1998 15:40:12 -0800 (PST)

- Messages sorted by: [ date ][ thread ][ subject ][ author ]
- Next message: Bob McElrath: "Re: proper ioport space allocation"
- Previous message: Chad C. Keep: "Re: bug causes tcp/ip stack corruption"

On Fri, 18 Dec 1998, Trond Myklebust wrote:
>
> You forget that it is also still done in the code for
> nfs_truncate_dirty_pages() which again is called by
> nfs_notify_change().

Gaah. I should just remove that piece of horrid special casing completely,
your patch should make it completely irrelevant. Good riddance.

And good spotting, you're obviously completely right.

> See the appended patch. I haven't removed the call to
> nfs_truncate_dirty_pages, but that should probably be done (and the
> routine deleted) since it is broken.

Yes, I removed it after applying your patch. This could easily explain the
problems some people still saw.

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

- Next message: Bob McElrath: "Re: proper ioport space allocation"
- Previous message: Chad C. Keep: "Re: bug causes tcp/ip stack corruption"