Linux-kernel mailing list archive 1999-34,: Re: small patch for do_wp_page

# Re: small patch for do_wp_page

Philip Blundell (pb@nexus.co.uk)
Thu, 26 Aug 1999 11:17:21 +0100

- Messages sorted by: [ date ][ thread ][ subject ][ author ]
- Next message: Rus V. Brushkoff: "2.3.15 fbcon oops"
- Previous message: Alexander Sokolov: "Telsat Turbo for Linux"
- Maybe in reply to: Philip Blundell: "small patch for do_wp_page"
- Next in thread: David S. Miller: "Re: small patch for do_wp_page"

>You understand it just fine, however you believe that copy_cow_page is
>actually passed ZERO_PAGE in the instance where you removed the flush.
>Your change is to remove the flush from this stretch of code:
>
>linux/mm/memory.c:~line 823
>
> copy_cow_page(old_page,new_page);
> flush_page_to_ram(old_page);
> flush_page_to_ram(new_page);
>
>What is the invariant which makes you believe that
>"old_page == ZERO_PAGE(new_page)" at this spot each
>and every time?

Nothing, but you overlooked the other part of my patch. I also added a
flush into copy_cow_page() in the case where old_page != ZERO_PAGE.

p.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

- Next message: Rus V. Brushkoff: "2.3.15 fbcon oops"
- Previous message: Alexander Sokolov: "Telsat Turbo for Linux"
- Maybe in reply to: Philip Blundell: "small patch for do_wp_page"
- Next in thread: David S. Miller: "Re: small patch for do_wp_page"