Linux-kernel mailing list archive 1999-34,: [2.2.11 nitpick patch] USB Mouse naming vague

# [2.2.11 nitpick patch] USB Mouse naming vague

Aaron Tiensivu (mojomofo@ctechnix.com)
Fri, 27 Aug 1999 17:39:20 -0400

- Messages sorted by: [ date ][ thread ][ subject ][ author ]
- Next message: Mark Hahn: "Re: Bad blocks on hdb2?"
- Previous message: Lawrence Manning: "disk holdup with dd and fsync()"

--MW5yreqqjyrRcusr
Content-Type: text/plain; charset=us-ascii

This has been irritating me for a while so I ended up making a patch
for it just for consistency sake. :)

The USB mouse section of the USB code links as "mouse.o" which is pretty vague,
especially when you're building a totally modular kernel.

This patch simply renames that section to 'usb-mouse.c' and I'm providing
a modded Makefile for the change. Simply apply the patch and rename mouse.c
in the usb directory to usb-mouse.c and you'll be golden.

Other minor nit: All the USB files use '-' as a seperator but the USB SCSI code
uses '_' as a seperator.

Strange thing I noticed: gpm segfaults unless you insert:
"post-install usb-uhci modprobe -k usb-mouse"
when using modular USB code.

    --
    Which is worse, ignorance or apathy? Who knows? Who cares?
    I'm not a perfectionist, but I'm working on it.
    Buckcherry in 10 years: "I love the Rogaine. I love the Rogaine."

    --MW5yreqqjyrRcusr
    Content-Type: text/plain; charset=us-ascii
    Content-Disposition: attachment; filename="2.2.11-usbmouse.patch"

    --- linux/drivers/usb/Makefile.virgin	Fri Aug 27 17:24:09 1999
    +++ linux/drivers/usb/Makefile	Fri Aug 27 17:25:07 1999
    @@ -53,11 +53,11 @@
     endif

     ifeq ($(CONFIG_USB_MOUSE),y)
    -  L_OBJS += mouse.o
    +  L_OBJS += usb-mouse.o
     endif
     ifeq ($(CONFIG_USB_MOUSE),m)
    -  M_OBJS  +=mouse.o
    -  MIX_OBJS +=mouse.o
    +  M_OBJS  +=usb-mouse.o
    +  MIX_OBJS +=usb-mouse.o
     endif

     ifeq ($(CONFIG_USB_HUB),y)

    --MW5yreqqjyrRcusr--

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.rutgers.edu
    Please read the FAQ at http://www.tux.org/lkml/

- Next message: Mark Hahn: "Re: Bad blocks on hdb2?"
- Previous message: Lawrence Manning: "disk holdup with dd and fsync()"