Re: ip_queue_xmit(): dangling skb pointer (with patch)

David S. Miller (davem@redhat.com)
Mon, 6 Sep 1999 19:23:01 -0700


From: Henner Eisen <eis@baty.hanse.de>
Date: 06 Sep 1999 23:49:28 +0200

maybe my previous posting got lost somehow (didn't receive any reponse).

There is a bug in ip_output.c:ip_queue_xmit().

It didn't get lost, I've applied your patch.

BTW: Is there any reason why the setting of the new skb's ownership is not
done within skb_realloc_headroom() itself?

Every time we've added an implicit side effect to a generic SKB
routines, it has lead to problems and hard to track down bugs. And it
is probably someone will find a situation where they _do not_ want to
set the new skb's ownership.

Later,
David S. Miller
davem@redhat.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/