Linux-kernel mailing list archive 1999-51,: Re: [PATCH] CDROMPLAYTRKIND was broken

# Re: [PATCH] CDROMPLAYTRKIND was broken

Jens Axboe (axboe@image.dk)
Tue, 21 Dec 1999 00:52:16 +0000

- Messages sorted by: [ date ][ thread ][ subject ][ author ]
- Next message: Ted Sikora: "Re: [Fwd: Dual Celery on BP6]"
- Previous message: pm: "2.2.12 & IDE cdwriters"

On Mon, Dec 20 1999, Peter Samuelson wrote:
> Jens, *,
>
> A fencepost error in drivers/cdrom/cdrom.c was causing CDs to play one
> track less than you asked for (with the CDROMPLAYTRKIND ioctl). Then
> in 2.3.31 or so it broke entirely. The following seems to make it work
> again. NOTE: I only tested ide-cd since that's all I have.

Thanks, applied here.

> + if (entry.cdte_track == tochdr.cdth_trk1 + 1)
> + entry.cdte_track = CDROM_LEADOUT;

This part doesn't make sense, though. Why would you want to select
the lead out?

    --
    *  Jens Axboe <axboe@image.dk>
    *  Linux CD-ROM Maintainer
    *  http://www.kernel.dk

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.rutgers.edu
    Please read the FAQ at http://www.tux.org/lkml/

- Next message: Ted Sikora: "Re: [Fwd: Dual Celery on BP6]"
- Previous message: pm: "2.2.12 & IDE cdwriters"