[FIX] Typo in i386/head.S ?

Willy Tarreau (willy@novworld.Novecom.Fr)
Sun, 2 Jan 100 22:37:41 +0100 (CET)


Hi all,

I've noticed something strange in 2.2.14pre18 and 2.3.35, file
asm/i386/boot/compressed/head.S, at line 56, I think it's a typo :

pushl 0 # Clear NT
popfl

Shouldn't this be "pushl $0" instead of "pushl 0" ?
Blame me if I'm wrong, but for me "pushl 0" pushes the address of the
int 0 handler instead of the value 0 so the flag contents may be
unpredictable. Only the SMP code is concerned.

Just my 2 cents ...

Best Wishes,
Willy

--
Willy Tarreau - willy@meta-x.org - http://www-miaif.lip6.fr/willy/
System and Network Engineer at NOVECOM - http://www.novecom.fr/
Magistere d'Informatique Appliquee de l'Ile de France ( MIAIF ), Year 1997

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/