Re: tiny patch: fix drivers/scsi/seagate.c module parameters in 2.2.13
Keith Owens (kaos@ocs.com.au)
Mon, 3 Jan 2000 03:18:06 +0200
On Sun, 2 Jan 2000 16:44:43 -0500 (EST),
Bradley M Keryan <keryan@andrew.cmu.edu> wrote:
>In all of the 2.2.x kernels I've looked at, drivers/scsi/seagate.c doesn't
>have any MODULE_PARM() in it. When compiled as a module (like on the RH6.1
>install disks) it is pretty much useless for cards that don't have a BIOS.
>
>--- linux/drivers/scsi/seagate.c.orig Sat Jan 1 20:16:30 2000
>+++ linux/drivers/scsi/seagate.c Sun Jan 2 11:26:07 2000
>@@ -250,6 +250,12 @@
> boards */
> static int irq = IRQ;
>
>+#ifdef MODULE
>+MODULE_PARM(base_address, "i");
>+MODULE_PARM(controller_type, "b");
>+MODULE_PARM(irq, "i");
>+#endif
>+
No need to wrap MODULE_PARM in #ifdef MODULE. The module.h code does
that already, all you do is clutter up the mainline code.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/