Re: [FIX] Typo in i386/head.S ?

Richard B. Johnson (root@chaos.analogic.com)
Mon, 3 Jan 2000 03:49:15 +0200


On Sun, 2 Jan 100, Willy Tarreau wrote:

> Hi all,
>
> I've noticed something strange in 2.2.14pre18 and 2.3.35, file
> asm/i386/boot/compressed/head.S, at line 56, I think it's a typo :
>
> pushl 0 # Clear NT
> popfl
>
> Shouldn't this be "pushl $0" instead of "pushl 0" ?
> Blame me if I'm wrong, but for me "pushl 0" pushes the address of the
> int 0 handler instead of the value 0 so the flag contents may be
> unpredictable. Only the SMP code is concerned.
>
> Just my 2 cents ...
>

Should have a $, no doubt at all. However, depending upon DS at the
time, I wouldn't count on offset-zero containing anything useful.

Cheers,
Dick Johnson

Penguin : Linux version 2.3.13 on an i686 machine (400.59 BogoMips).

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/