Re: PCI resource allocation (was Re: Ok, making ready for pre-2.4 and

[Jeff Garzik]

Thomas Sailer wrote:
> 
> Martin Mares wrote:
> 
> >    pci_assign_resource() is already present in pre-2.3.35.
> 
> Thanks, but on the machine where I have the sonicvibes installed,
> 2.3.35 crashes very early during boot.
> 
> It oopses in ncr53c8xx_pci_init, just after the call to
> ncr_get_Tekram_nvram, when it tries to execute nvram->type = 0;,
> the nvram pointer seems to be bogus...
> 
> Any idea what went wrong?

Thanks, I have been looking for this bug!

I am not looking at the code right now, but I'll bet that "nvram" is a
pointer to PCI memory.  On most Alphas, including mine, you cannot
directly de-reference memory like that.  Just a guess, but the code
should probably look like

	writel (0, &nvram->type);

Let me know if a patch emerges out of this (before I fix it), because I
cannot boot my alpha at the moment.  I haven't had time to look at Alpha
much due to the upcoming Mandrake release, otherwise it is probably a
5-minute fix...

	Jeff

-- 
Jeff Garzik         | Another priceless gem from slashdot:
Building 1024       | "I use Mandrake for the same reason I flip the
MandrakeSoft, Inc.  |  lightswitch 17 times every time I leave the
room...
                    |  If I don't, my family will die."