Re: First draft list of 2.3.x "Things to fix"

Alan Cox (alan@lxorguk.ukuu.org.uk)
Wed, 5 Jan 2000 01:30:31 +0000 (GMT)


> including mine. With the proliferation of ext2 resizing tools, this sure
> would be sweet; LVM could have saved my butt a few times in the last few
> years.
>
> Any numbers on the "minimal" performance loss of the extra layer?

When I tried it for a bit in 2.2.x-ac I couldnt measure any.

The reason I gave up adding it to -ac was that I cleaned it up , I fixed it for the
Coding Style document and I fixed some bugs. I got an update from the author that simply
ignored all that work and reverted to wrong formats.

Every annoyance I personally have with the LVM code comes down to two things
1. Not following the Coding Style
2. General poor readability - lots of complex loops, huge ioctl functions

The main thing it made me wonder was if the ioctl interface layer was perhaps structured
badly and perhaps using different ways to pass the data would avoid a lot of the mess
in the existing code.

The actual remapping code is fast, clean and works. It also has about zero impact if the
LVM is disabled.

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/