Re: [patch] arch/i386/setup.S bug

[Chris Noe]

On Tue, 4 Jan 2000, Tigran Aivazian wrote:

> a long time ago (when it was still written in as86) I converted all movsw
> to movsd and (the part, relevant to the above, of ) my patch looked like
> this:
[...]
> see that 8 becoming 7 and 3 becoming 2 above? Now, the current version
> uses movsw and yet we still have 7 and 2 instead of 8 and 3. This is just
> a "surface look" which makes me think it is obviously incorrect. 
> 
> Anyway, I think it is wrong and here is the patch to fix it:
> 
> http://www.ocston.org/~tigran/patches/setup-2.3.36-p6.patch

Yep, definitely my bad. The problem that I saw was that although movsd's
are generally always a win over movsw's, throughout the bootcode we're in
.code16 which means we get an addr32 prefix byte on each one (with gas;
I'm assuming as86 did as well).

I changed it and the corresponding "four sector" line.. but apparently
glossed right over the other relevant lines (even with "convert to
_dwords_" right there). :)

Chris Noe
([e-mail])