RE: Memory detection is still broken in 2.3.36

Readability is in the eye of the beholder.  For some reason, 8 digits is the
most that I easily grep.

Nathan

-----Original Message-----
From: david parsons [mailto:[e-mail]]
Sent: Friday, January 07, 2000 12:29 PM
To: Zook, Nathan
Cc: [e-mail]; [e-mail];
[e-mail]; [e-mail];
[e-mail]; [e-mail]
Subject: Re: Memory detection is still broken in 2.3.36

Ack!

[e-mail] wrote:
> e820.map[0]);
>  #ifdef E820_DEBUG
>  		for (i=0; i < e820.nr_map; i++) {
> -			printk("e820: %08x @ %08x ", (int)e820.map[i].size,
> -						(int)e820.map[i].addr);
> +	printk("%lx %08lx  %lx %08lx  ",
> +			(long)((e820.map[i].addr) >> 32),(long)
(e820.map[i].addr),
> +			(long)((e820.map[i].size) >> 32), (long)
(e820.map[i].size));

    No No No!

    Use %10Lx to print out long long values, don't shift and print out 2
longs.
    Yes, it's expensive and ugly and horrible, but it's debugging code that
    will be ifdeffed out in the production kernel and it's more readable
until
    then.

                  ____
    david parsons \bi/ Ack. Pfft.
                   \/