Re: dev->tx_timeout not being called in 2.3.4[345]

[Linux Lists]

On Wed, 16 Feb 2000 [e-mail] wrote:
> 
> >     if(dma_buf_write(card, ch, (ucchar *)skb->data, skb->len) != 0) {
> >         netif_wake_queue(dev);
> 
> Seems, it should be netif_stop_queue() yet?

No, in that case (in which there was a failure to write to the DMA TX
buffers), I'll discard that packet and restart the queue.

The thing is, as pointed out by Andi Kleen <[e-mail]>, that I wans't
doing netif_stop_queue when the packet was successfully sent to the
hardware. Now everything is correct.

Anyhow, thanks for your answer!

Regards,
Ivan