Re: Kernel code analysis (was Re: "movb" for spin-unlock (was Re:

Jan Evert van Grootheest (janevert@iae.nl)
Tue, 25 Apr 2000 09:05:03 +0200


This is a cryptographically signed message in MIME format.

--------------ms0B530A4A3FDDB2017CB0A946
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Jeff,

Jeff Garzik wrote:
> The tool which I envision need only handle simple stuff at first. As
> long as the source code analyzer knows C code at a semantic level, I
> need only write extra rules / regexes to catch basic but very common
> driver code errors.
>
> It is too much to ask "kernel-lint" to puzzle through page cache flag
> arcana for example, but I can think of a ton of simple things that a
> kernel-lint tool could scan for that would be useful..
> * divide by power of two, instead of shifting
> * calling pci_find_xxx functions without pci_enable_device somewhere in
> the driver
> * calling MOD_INC_USE_COUNT in a function AFTER a call to request_irq or
> a similar function which may sleep
> [...]
>
> It's still a tall order to handle simple stuff like this.. Further, it
> is granted that all rules are generally broken for a good reason at
> least once. but such a tool IMHO would be invaluable to people
> maintaining kernel drivers.

That's a really good idea. And it's not only useful for people
maintaining things, but also for newbies trying to get work done but
have no idea (yet)(like me, still).
Perhaps you could start writing down the rules? Or are those already
written down somewhere?

-- Jan Evert
--------------ms0B530A4A3FDDB2017CB0A946
Content-Type: application/x-pkcs7-signature; name="smime.p7s"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="smime.p7s"
Content-Description: S/MIME Cryptographic Signature

MIIH5gYJKoZIhvcNAQcCoIIH1zCCB9MCAQExCzAJBgUrDgMCGgUAMAsGCSqGSIb3DQEHAaCC
BbcwggKbMIICBKADAgECAgMCG8MwDQYJKoZIhvcNAQEEBQAwgZQxCzAJBgNVBAYTAlpBMRUw
EwYDVQQIEwxXZXN0ZXJuIENhcGUxFDASBgNVBAcTC0R1cmJhbnZpbGxlMQ8wDQYDVQQKEwZU
aGF3dGUxHTAbBgNVBAsTFENlcnRpZmljYXRlIFNlcnZpY2VzMSgwJgYDVQQDEx9QZXJzb25h
bCBGcmVlbWFpbCBSU0EgMTk5OS45LjE2MB4XDTAwMDIxNDIxNDgxOVoXDTAxMDIxMzIxNDgx
OVowQTEfMB0GA1UEAxMWVGhhd3RlIEZyZWVtYWlsIE1lbWJlcjEeMBwGCSqGSIb3DQEJARYP
amFuZXZlcnRAaWFlLm5sMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDWSwi12JDxNsr2
dru+ma04WV4Uo8lqZ+v8ERWBAYkrmP5u28kvcDSGdXagoqmGeWvybcdNz7XDkHTmxSAUMRpB
t0B7wYPFQkxbOpRzqDcmBKZyjSSbe90qwvqnlP5vy62daSG6lF8iegjlYrn+T7Zk4jk5Ms/G
NQ+dCJOKdZOA3QIDAQABo00wSzAaBgNVHREEEzARgQ9qYW5ldmVydEBpYWUubmwwDAYDVR0T
AQH/BAIwADAfBgNVHSMEGDAWgBSIq/Fgg2ZV9ORYx0YdwGG9I9fDjDANBgkqhkiG9w0BAQQF
AAOBgQAlKW7ER50JpcVwB/jR4L38/d/+emw21+WF9mqDk9B8xm6kvgIojF5DRf8qfB5CJmyY
h5PFE6D6jxklak7k/rFksf3tzFB/5nsCTreZcqW4s6YA9PoGHOZHOP8HxSFRC6WwsTdUe8v3
rf1tgRijOXSC0mOqAoAU1NVOsy3eDk6hiDCCAxQwggJ9oAMCAQICAQswDQYJKoZIhvcNAQEE
BQAwgdExCzAJBgNVBAYTAlpBMRUwEwYDVQQIEwxXZXN0ZXJuIENhcGUxEjAQBgNVBAcTCUNh
cGUgVG93bjEaMBgGA1UEChMRVGhhd3RlIENvbnN1bHRpbmcxKDAmBgNVBAsTH0NlcnRpZmlj
YXRpb24gU2VydmljZXMgRGl2aXNpb24xJDAiBgNVBAMTG1RoYXd0ZSBQZXJzb25hbCBGcmVl
bWFpbCBDQTErMCkGCSqGSIb3DQEJARYccGVyc29uYWwtZnJlZW1haWxAdGhhd3RlLmNvbTAe
Fw05OTA5MTYxNDAxNDBaFw0wMTA5MTUxNDAxNDBaMIGUMQswCQYDVQQGEwJaQTEVMBMGA1UE
CBMMV2VzdGVybiBDYXBlMRQwEgYDVQQHEwtEdXJiYW52aWxsZTEPMA0GA1UEChMGVGhhd3Rl
MR0wGwYDVQQLExRDZXJ0aWZpY2F0ZSBTZXJ2aWNlczEoMCYGA1UEAxMfUGVyc29uYWwgRnJl
ZW1haWwgUlNBIDE5OTkuOS4xNjCBnzANBgkqhkiG9w0BAQEFAAOBjQAwgYkCgYEAs2lal9TQ
Fgt6tcVd6SGcI3LNEkxL937Px/vKciT0QlKsV5Xje2F6F4Tn/XI5OJS06u1lp5IGXr3gZfYZ
u5R5dkw+uWhwdYQc9BF0ALwFLE8JAxcxzPRB1HLGpl3iiESwiy7ETfHw1oU+bPOVlHiRfkDp
nNGNFVeOwnPlMN5G9U8CAwEAAaM3MDUwEgYDVR0TAQH/BAgwBgEB/wIBADAfBgNVHSMEGDAW
gBRyScJzNMZV9At2coF+d/SH58ayDjANBgkqhkiG9w0BAQQFAAOBgQBrxlnpMfrptuyxA9jf
cnL+kWBI6sZV3XvwZ47GYXDnbcKlN9idtxcoVgWL3Vx1b8aRkMZsZnET0BB8a5FvhuAhNi3B
1+qyCa3PLW3Gg1Kb+7v+nIed/LfpdJLkXJeu/H6syg1vcnpnLGtz9Yb5nfUAbvQdB86dnoJj
Ke+TCX5V3jGCAfcwggHzAgEBMIGcMIGUMQswCQYDVQQGEwJaQTEVMBMGA1UECBMMV2VzdGVy
biBDYXBlMRQwEgYDVQQHEwtEdXJiYW52aWxsZTEPMA0GA1UEChMGVGhhd3RlMR0wGwYDVQQL
ExRDZXJ0aWZpY2F0ZSBTZXJ2aWNlczEoMCYGA1UEAxMfUGVyc29uYWwgRnJlZW1haWwgUlNB
IDE5OTkuOS4xNgIDAhvDMAkGBSsOAwIaBQCggbEwGAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEH
ATAcBgkqhkiG9w0BCQUxDxcNMDAwNDI1MDcwNTAzWjAjBgkqhkiG9w0BCQQxFgQUCSkoRcIJ
EwOWdbXLSibQo4q6HtUwUgYJKoZIhvcNAQkPMUUwQzAKBggqhkiG9w0DBzAOBggqhkiG9w0D
AgICAIAwBwYFKw4DAgcwDQYIKoZIhvcNAwICAUAwDQYIKoZIhvcNAwICASgwDQYJKoZIhvcN
AQEBBQAEgYBhrM4pYjTuYrYF8U12cktF5VRS8Jd6ftIzEiUiUXk98tsXSqjtwbGA5Ub8RW5j
0ANGAblrr0kll4exFEMvmRa90TIwTEwV5Ec8vBZ+nYUDielECDw3KccCig3v9sG7RShEuYJo
wD7VdGjURpprZsZEHgrXM+CytFKxKXgLYphNXA==
--------------ms0B530A4A3FDDB2017CB0A946--

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/