Re: [PATCH] Generic dead function optimisation

Kurt Roeckx (Q@ping.be)
Tue, 25 Apr 2000 23:38:52 +0200

On Tue, Apr 25, 2000 at 08:01:31PM +0200, Olaf Titz wrote:
>
> That's not what I wrote. "static" means _this symbol_ can not be
> referenced from outside the compilation unit. In your example the
> symbol is referenced only inside the module, by the structure
> initializer.

I know one place that uses static wrongly atleast. I've even mailed a
patch that just removes the static more then once.

In net/ipv6/ip6_fib.c:

static struct fib6_walker_t fib6_walker_list = {
&fib6_walker_list, &fib6_walker_list,
};

Then in include/net/ip6_fib.h:

extern struct fib6_walker_t fib6_walker_list;

This is cleary plain wrong, and shouldn't even link properly.

<net/ip6_fib.h> in included in a few other places.

Kurt

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/