Re: [PATCH] rtc.c fix

Jeff Garzik (jgarzik@mandrakesoft.com)
Sat, 29 Apr 2000 14:52:18 -0400


Cesar Eduardo Barros wrote:
> It seems OK for me too (though showing /proc/rtc only after the test has been
> done adds nothing at all). I'll forward the patch to Linus now then (if it
> worked on SMP, no way in hell it's gonna break on my UPs unless my slow 386 can
> force the issue more than a faster box).

Well, I wouldn't make assumptions, and it is easy enough to test the UP
case on an SMP box -- just disable CONFIG_SMP.

After that testing though, I would say the patch looks ok. Thanks a
bunch for cleaning that up... I originally converted RTC over to using
locks, but did it a long time ago and without access to an SMP box. It
definitely needed updating.

Jeff

-- 
Jeff Garzik              | Nothing cures insomnia like the
Building 1024            | realization that it's time to get up.
MandrakeSoft, Inc.       |        -- random fortune

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/