Re: [PATCH] ac7 Athlon-SMP

Tom Leete (tleete@mountain.net)
Sun, 04 Jun 2000 15:33:17 -0400

willy@thepuffingroup.com wrote:
>
> On Sat, Jun 03, 2000 at 08:55:52AM -0400, Tom Leete wrote:
> >
> > Here is a fix for the K7-SMP compilation failures I reported yesterday.
> >
> > The memcpy3d functions are moved to arch/i386/lib/mmx.c with the
> > corresponding changes to asm-i386/mmx.h. This also allowed a cleanup
> > of asm-i386/string.h.
>
> this cannot be acceptable. you've turned two inline functions into function
> calls -- and memcpy has to be fast.

Principle of minimum damage. The alternative is to find a way to introduce in_interrupt()
much earlier in the build. The original code tried that and failed. So did I.

Please note that all the functions in mmx.c are similar in nature. The PREFETCH call for
those big L1 lines is a great compensator.

If you have a patch which preserves __inline__ and builds, too, I'd be delighted to test
it.

Regards,
Tom

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/