Re: EXT3 and umount hangs

[Stephen C. Tweedie]

--/9DWx/yDrRhgMJTb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi,

On Tue, May 30, 2000 at 02:19:04AM -0400, [e-mail] wrote:

> 	I've been using ext3 happily on a bunch of machines (primarily 0.0.2c
> on 2.2.13), and its been really stable. But today I tried installing it on a 
> 20GB WD205AA, and it appears that any attempt to umount some of the ext3 file
> systems after one reboot after installing ext3 hangs.

I'm putting together ext3-0.0.2e which addresses a couple of possible
problems.  The main one is that it was possible for a stray timer to be
left after an ext3 unmount if there was a commit pending when the umount
request came in --- could you try the patch below?

Cheers,
 Stephen

--/9DWx/yDrRhgMJTb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="ext3-timer.diff"

--- linux-2.2.15-ext3-0.0.2e/fs/jfs/journal.c.~1~	Fri May 12 11:45:45 2000
+++ linux-2.2.15-ext3-0.0.2e/fs/jfs/journal.c	Fri May 12 16:27:36 2000
@@ -131,6 +131,11 @@
 			journal->j_commit_request = transaction->t_tid;
 	}
 	
+	if (journal->j_commit_timer_active) {
+		journal->j_commit_timer_active = 0;
+		del_timer(journal->j_commit_timer);
+	}
+
 	journal->j_task = NULL;
 	wake_up(&journal->j_wait_done_commit);
 	jfs_debug(1, "Journal thread exiting.\n");

--/9DWx/yDrRhgMJTb--