Linux-kernel mailing list archive 2000-23,: Re: [PATCH] 2.4.0-test1-ac12 - epic100.c

# Re: [PATCH] 2.4.0-test1-ac12 - epic100.c

Jeff Garzik (jgarzik@mandrakesoft.com)
Sat, 10 Jun 2000 13:55:20 -0400

- Messages sorted by: [ date ][ thread ][ subject ][ author ]
- Next message: Xuan Baldauf: "Patch: isdn for devfsd"
- Previous message: Richard Gooch: "[PATCH] devfs v99.15 available"
- Maybe in reply to: Francois romieu: "[PATCH] 2.4.0-test1-ac12 - epic100.c"

Francois romieu wrote:
>
> Take the following for what it's worth.
> Here :
> - the code compiles,
> - the module ceases to BUG,
> - ping -f looks right,
> - love and wealth are back.
>
> --- linux-2.4.0-test1-ac12.orig/drivers/net/epic100.c Sat May 13 11:19:21 2000
> +++ linux-2.4.0-test1-ac12/drivers/net/epic100.c Sat Jun 10 14:45:14 2000
> @@ -1054,7 +1056,7 @@
> printk(KERN_DEBUG " In epic_rx(), entry %d %8.8x.\n", entry,
> ep->rx_ring[entry].rxstatus);
> /* If we own the next entry, it's a new packet. Send it up. */
> - while ( ! le32_to_cpu(ep->rx_ring[entry].rxstatus) & DescOwn) {
> + while (!(le32_to_cpu(ep->rx_ring[entry].rxstatus) & DescOwn)) {
> int status = le32_to_cpu(ep->rx_ring[entry].rxstatus);
>
> if (debug > 4)

Well that's pretty dandy. I already caught the pdev->driver_data bug,
but if this solves the remaining problems with the driver I'm happy. I
can test this weekend and see how things look.

Thanks!

Jeff

    --
    Jeff Garzik              | Liberty is always dangerous, but
    Building 1024            | it is the safest thing we have.
    MandrakeSoft, Inc.       |      -- Harry Emerson Fosdick

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.rutgers.edu
    Please read the FAQ at http://www.tux.org/lkml/

- Next message: Xuan Baldauf: "Patch: isdn for devfsd"
- Previous message: Richard Gooch: "[PATCH] devfs v99.15 available"
- Maybe in reply to: Francois romieu: "[PATCH] 2.4.0-test1-ac12 - epic100.c"