Re: RFC: Modularize /proc/partitons (was Re: /proc/partitions for LVM)

Peter Samuelson (peter@cadcamlab.org)
Thu, 23 Nov 2000 21:48:38 -0600


[Brian Kress]
> 1) Add a function pointer to struct gendisk called hd_name.
>
> 2) Make disk_name in fs/partitions/check.c use that function
> pointer if its non-null.
>
> 3) Change the following drivers to use this method. (adding the
> driver specific method and removing the old code in check.c)

Looks good to me ... except that cpqarray.c, cciss.c and DAC960.c have
basically duplicate functions. Would this be a net win:

char *typical_disk_name(struct gendisk *, int major_base, int minor, char *buf);

...exported from check.c?

Peter
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/