Re: PATCH for 2.4.0: assign ad1848 mixer operations to correct module

Alan Cox (alan@lxorguk.ukuu.org.uk)
Mon, 8 Jan 2001 14:37:29 +0000 (GMT)


> +
> + if (owner)
> + ad1848_mixer_operations.owner = owner;
> +
> if ((e = sound_install_mixer(MIXER_DRIVER_VERSION,
> dev_name,
> &ad1848_mixer_operations,
>
> BTW Isn't it ever-so-slightly dodgy modifying the static

Very.

> operations in exactly the same way as the ad1848_audio_driver
> structure, but doesn't this mean that the ad1848_init() function now
> "remembers" the owner from the previous call?

Yeah

> Or maybe the sound_install_XXXX() functions should accept "owner"
> parameters, so that the static structs could become "const"?

I think you either need owner as a parameter or to make a copy of the
ad1848_mixer_operations in your sscape driver and pass that ?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/