Re: wavelan has fatal error with 2.4.0 (but worked in 2.4.0-test12)

[Jean Tourrilhes]

On Tue, Jan 09, 2001 at 05:13:42PM +0000, Alan Cox wrote:
> > 	This is a bug with the definition of udelay(). Somebody tried
> > to be too clever with udelay(), and the end result is that it breaks
> > perfectly good and valid code.
> > 	Therefore, it should be reported as such on LKML, a bug in udelay().
> 
> It is a bug in the driver.

	Please check again the code and point me the invalid
udelay(). You will realise that there is no delay in the driver that
is longer than 100ms.
	The bug is that udelay() can't be passed a variable but only a
constant. Therefore bug in udelay().

> > there. For my part, I insist that the code is correct, that replacing
> > an inline function by a #define is going backwards and that udelay()
> > should be fixed one way or another (easy, just define __bad_udelay()
> > as returning a compilation warning or an error message).
> 
> You can't #define a function to a #warning or #error in C. Language limitation

	Yes. Tough.

	Jean