Re: [PATCH] advansys.c: include missing restore_flags, etc

Ralf Baechle (ralf@conectiva.com.br)
Wed, 10 Jan 2001 05:48:11 -0200


On Tue, Jan 09, 2001 at 08:30:07AM +0100, Pauline Middelink wrote:

> > -STATIC int
> > +STATIC unsigned long
> > DvcEnterCritical(void)
> > {
> > - int flags;
> > + unsigned long flags;
> >
> > save_flags(flags);
> > cli();
> > @@ -9965,7 +9972,7 @@
> > }
>
> Err, according tho wise ppl on this list, this does not work on
> MIPSes. The flags thing must stay in the same stackframe.

Nope, that's on Sparc.

> > STATIC void
> > -DvcLeaveCritical(int flags)
> > +DvcLeaveCritical(unsigned long flags)
> > {
> > restore_flags(flags);
> > }
>
> Item.

My Latin teach says it's ``idem''.

Ralf

--
"Embrace, Enhance, Eliminate" - it worked for the pope, it'll work for Bill.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/