Re: 2.4.2-pre1

Tom Rini (trini@kernel.crashing.org)
Tue, 6 Feb 2001 11:36:15 -0700


On Sat, Feb 03, 2001 at 08:24:27PM -0800, Linus Torvalds wrote:

...
> -pre1:
...
> - riva FB driver update

Er, what exactly is the CONFIG_PREP stuff in this driver supposed to be
for? "CONFIG_PREP" doesn't exist anymore to start with, and secondly I'm
not sure if any PReP boxes ever shipped with a riva card to start with. The
only real way to handle this in 2.4 is something like:
#ifdef CONFIG_ALL_PPC /* CHRP/PMAC/PREP */
#include <asm/processor.h>
#define isPReP (_machine == _MACH_prep)
#else
#define isPReP 0
#endif

That is, if there's really any need to test explicitly for a PReP box.
I asked Ani Joshi about this a while ago, and he wasn't quite sure why they
were in there either..

-- 
Tom Rini (TR1265)
http://gate.crashing.org/~trini/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/