Re: [PATCH] s/isa//g in drivers/scsi/g_NCR5380.c and some cleanup (242)

[Alan Cox]

> Looking at the define of NCR_5380_write
> 
> #define NCR5380_write(reg, value) isa_writeb(NCR5380_map_name + +NCR53C400_mem_base + (reg), value)
> 
> followed by an use of NCR5380_write
> 
>     NCR5380_write(C400_CONTROL_STATUS_REG, CSR_BASE | CSR_TRANS_DIR);
> 
> I doubt that it is not the intention to write CSR_BASE | CSR_TRANS_DIR
> at the offset C400_CONTROL_STATUS_REG. But note that this argument
> swap only is in the code produced by -DCONFIG_SCSI_G_NCR5380_MEM.
> Perhaps you use CONFIG_SCSI_G_NCR5380_PORT? Otherwise I must admit
> that I have been had...

Im running PIO. However while I agree with that one Im dubious about the
inverts on the memcpy_*io bits

Alan