Re: [PATCH] /drivers/char/serial.c cleanup

[Philipp Rumpf]

On Mon, Mar 05, 2001 at 03:37:04PM +0300, Andrey Panin wrote:
> Attached patch (2.4.2-ac11) makes some changes in serial driver:
> adds ioremap() return code checks, removes panic() calls
> and adds better error handling in start_pci_pnp_board() function.

Did you test it ?

> diff -u /linux.vanilla/drivers/char/serial.c /linux/drivers/char/serial.c
> --- /linux.vanilla/drivers/char/serial.c	Thu Mar  1 20:15:43 2001
> +++ /linux/drivers/char/serial.c	Fri Mar  2 00:10:29 2001
> @@ -3876,7 +3876,10 @@
>  		return 0;
>  	}
>  	req->io_type = SERIAL_IO_MEM;
> -	req->iomem_base = ioremap(port, board->uart_offset);
> +	if ((req->iomem_base = ioremap(port, board->uart_offset))) {
> +		printk(KERN_ERR "serial: Couldn's remap IO memory at %#lx\n", port);
> +		return 1;
> +	}

This seems wrong.  ioremap returns NULL in case of failure.