Re: 2.4.2 fs/inode.c

Chris Mason (mason@suse.com)
Mon, 26 Mar 2001 12:51:46 -0500


On Thursday, March 22, 2001 01:42:15 PM -0500 Jan Harkes
<jaharkes@cs.cmu.edu> wrote:

>
> I found some code that seems wrong and didn't even match it's comment.
> Patch is against 2.4.2, but should go cleanly against 2.4.3-pre6 as well.
>

Ok, this looks correct, makes reiserfs faster, and survived under load. The
idea was to only call dirty_inode if sync_one might decide the inode needs
flushing to disk. So, the check in __mark_inode_dirty should look the same
as the check in sync_one.

> --- linux/fs/inode.c.orig Thu Mar 22 13:20:55 2001
> +++ linux/fs/inode.c Thu Mar 22 13:21:32 2001
> @@ -133,7 +133,7 @@
>
> if (sb) {
> /* Don't do this for I_DIRTY_PAGES - that doesn't actually dirty the
> inode itself */
> - if (flags & (I_DIRTY | I_DIRTY_SYNC)) {
> + if (flags & (I_DIRTY_SYNC | I_DIRTY_DATASYNC)) {
> if (sb->s_op && sb->s_op->dirty_inode)
> sb->s_op->dirty_inode(inode);
> }
> -

-chris

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/