> The attached patch does two things:
>
> 1) Take PCI devices to D0 state before enabling them. We both think
> this is the right thing to do, but there is always the crazy chance this
> change will break something. So, think twice before applying, but IMHO
> apply :)
I'm not able to cite the PCI PM specs by heart :) ... but looks OK to me.
> 2) Adds pci_disable_device. Right now is just disables busmastering.
> When suspending devices, the last task that should occur is to disable
> busmastering, before ceding control to ACPI. Also its a good idea in
> general to disable busmastering when its not in use; it's friendlier to
> the bus.
OK.
> When unloading drivers too, we should be more "green" about
> disabling devices.
Yes, but not before we're sure we can wake them up correctly. Probably
also needs to handle wakeup of PCI-to-PCI bridges.
> I wonder if we should disable IO and MEM decoding too, and I also like
> to ack PCI_STATUS. I didn't add those things because I'm not yet sure
> we want to do that unconditionally.
I'd rather prefer to avoid this. It brings nothing except for possible
problems.
Have a nice fortnight
-- Martin `MJ' Mares <mj@ucw.cz> <mj@suse.cz> http://atrey.karlin.mff.cuni.cz/~mj/ Compatible: Gracefully accepts erroneous data from any source. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/