Re: [PATCH] proc_lookup not exported

Jeff Golds (jgolds@resilience.com)
Wed, 18 Apr 2001 09:37:15 -0700


Alexander Viro wrote:
>
> On Tue, 17 Apr 2001, Jeff Golds wrote:
>
> > Hi folks.
> >
> > I noticed that proc_lookup is not exported in fs/proc/procfs_syms.c but
> > that the function is an external in include/linux/proc_fs.h.
>
> Not every public function needs to be exported. proc_lookup() is
> shared between different files in fs/proc/, so it can't be made
> static. However, it got no business being used outside of the
> fs/proc and it certainly shouldn't be used in modules.
>

I don't see why not. I created my own mkdir and rmdir handlers in my
module. I'd like to use the lookup function that proc supplies instead
of supplying my own, why shouldn't I be allowed to do that? It's not as
if I am doing something other than what normally happens: I am
assigning inode_operations::lookup to be proc_lookup.

-Jeff

-- 
Jeff Golds
jgolds@resilience.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/