Feel free to send (I have a NM256AV card in that VAIO).
> Your patch looks ok to me and I would say apply it. But I also think it
> is incomplete.
>
> * there is no need for a linked list of cards, since
> pci_{get,set}_drvdata is used. This eliminates the list walk in
> nm256_remove
The problem is with device opens, which just pass numbers, most other
sound drivers still use linked lists.
Hmm, but via8xxxx_audio.c doesn't, I will take this as example.
> * the new PCI API has suspend/resume hooks, and those should be used in
> preference to register_pm_...
Ok, will have another look at the other issues.
And I hope my colleague brings his VAIO to work tomorrow ;)
Ciao, Marcus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/