Re: ext2 inode size (on-disk)

Alexander Viro (viro@math.psu.edu)
Thu, 19 Apr 2001 22:12:42 -0400 (EDT)


On Thu, 19 Apr 2001, Andreas Dilger wrote:

> Strange, I run "mke2fs -I 192 /dev/hdc2" and do not have a segfault or any
> problems with e2fsck or debugfs on the resulting filesystem. I'm running
> 1.20-WIP, but I don't think anything was changed in this area for some time.

May depend on the libc version/size of device/phase of the moon. I've
got segfaults with 1.18, 1.19 and 1.20-WIP on a Debian box with glibc
2.1.3-18 and 20Mb image. What really happens is memory corruption in
libe2fs (ext2_write_inode()), segfault comes later (usually in free()).

> Basically, packing inodes across block boundaries is TOTALLY broken.
> This can lead to all sorts of data corruption issues if one block is
> written to disk, and the other is not. For that matter, the same would

Yup.

> PS - is this a code cleanup issue, or do you have some reason that you want
> to increase the inode size?

Code cleanup
Al

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/