Re: Fix for SMP deadlock in autofs4

[Jeremy Fitzhardinge]

--FL5UXtIhxfXey3p5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Apr 20, 2001 at 10:59:43PM -0700, Linus Torvalds wrote:
> It's untested, but looks fairly obvious. It removes the increment, and
> changes autofs4_expire() to properly bump the count of the returned dentry
> (and callers will dput() it when done). This may be unnecessarily careful,
> but it's the RightThing(tm) to do.

I suppose so.  It is pretty paranoid, because of autofs4's extra reference it
can't (shouldn't) ever drop to zero until the filesystem allows it to drop to
zero.  In other words, if it helps, it's hiding another bug.  But you're right,
if this were a general routine, it should definitely return with an elevated
count.

> Jeremy, would you mind verifying that this WorksForYou(tm)?

Looks fine to me.  I'll give it a spin.

	J

--FL5UXtIhxfXey3p5
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iEYEARECAAYFAjrhMKAACgkQf6p1nWJ6IgKLOQCeMAveWjjn9C4UFUWNa31b75QR
XrgAn0XKzfY4zG5iYSjgc+OLZpyTjVQc
=nYh5
-----END PGP SIGNATURE-----

--FL5UXtIhxfXey3p5--