Re: pci_pool_free from IRQ

[Pete Zaitcev]

> From: "David S. Miller" <[e-mail]>
> Date: Tue, 8 May 2001 17:52:45 -0700 (PDT)

> Ummm... What Alan's saying is:
> 
> 1) Whatever driver is trying to shut down from IRQ context
>    is broken must be fixed.  pci_pool is fine.
> 
> 2) The Documentation/ files which suggest that such device
>    removal from IRQs is "OK" must be fixed because it is not
>    "OK" to handle device removal from IRQ context.
> 
> So Pete's change is not needed.  A fix for the documentation and
> broken drivers is needed instead.

David, I do not follow your logic here, sorry.

I wrote that a path exists from a function that is legal in
interrupt context (pci_pool_free) into a function that is
not legal in interrupt context (pci_free_consistent).
The change breaks that connection. Note that pci_pool_free
is called when driver operates normally.

When you write "fix documentation and broken drivers", you talk
about a fix for a part that processes PCI remove. This is entirely
fine by me. But I was talking about a regular interrupt procession
in driver. A fix in pci remove does not fix regular processing.

-- Pete