Re: [What the...] sti() in device_init()

David S. Miller (davem@redhat.com)
Thu, 17 May 2001 00:40:25 -0700 (PDT)


Alexander Viro writes:
> Folks, what the hell is sti(); doing in device_init()? It's
> done _much_ earlier (before calibrate_delay(); in start_kernel())
> and I don't see anything that would require repeating it...
>
> Looks bogus for me... Linus?

I'm pretty sure it's an unnecessary turd, and you can safely remove
it.

My memory is foggy on this, but I think it was in fact necessary a
long long time ago.

Later,
David S. Miller
davem@redhat.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/