Re: [PATCH] struct char_device

[Alexander Viro]

On Wed, 23 May 2001 [e-mail] wrote:

> I am not sure whether we agree or differ in opinion. I wouldn't mind
> 
> /* pairing for dev_t to bd_op/cd_op */
> struct bc_device {
>         struct list_head        bd_hash;
>         atomic_t                bd_count;
>         dev_t                   bd_dev;
>         atomic_t                bd_openers;
>         union {
> 		struct block_device_operations_and_data *bd_op;
> 		struct char_device_operations_and_data *cd_op;
> 	}
>         struct semaphore        bd_sem;
> };
> 
> typedef struct bc_device *kdev_t;

What for? What part of the kernel needs a device and doesn't know apriory
whether it's block or character one?

> and in an inode
> 
> 	kdev_t dev;
Useless. If you hope that block_device will help to solve rmmod races -
sorry, it won't. Wrong layer.

> 	dev_t rdev;
Reasonable.